Replace #lease_release_date with #lease_expiration_date #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#lease_release_date is not a valid method so threw an error when running jobs to create relationships. Replace method with #lease_expiration_date. Valid lease methods include: ``` parent_work.lease.methods.grep(/lease/)=> [:visibility_after_lease=, :lease_history=, :lease_expiration_date, :lease_expiration_date=, :lease_history, :visibility_after_lease, :visibility_during_lease, :visibility_during_lease=] ```
laritakr
approved these changes
Jun 24, 2024
ShanaLMoore
added a commit
to samvera/hyku
that referenced
this pull request
Jun 24, 2024
pulls in fix for undefined method ref: - scientist-softserv/iiif_print#360
ShanaLMoore
added a commit
to samvera/hyku
that referenced
this pull request
Jun 24, 2024
pulls in fix for undefined method ref: - scientist-softserv/iiif_print#360
ShanaLMoore
added a commit
to scientist-softserv/palni_palci_knapsack
that referenced
this pull request
Jun 24, 2024
pulls in fix for undefined method. #lease_release_date is not a valid method so threw an error ref: - scientist-softserv/iiif_print#360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#lease_release_date is not a valid method so threw an error when running jobs to create relationships. Replace method with #lease_expiration_date.
Valid lease methods include:
Story
Jobs seemed to have split but create relationships failed, so it doesn't look like it worked.
ref
Screenshots / Video
Error from the server
Notes