🐛 Handle blank query and snippets #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will address blank catalog searches and how it interacts with snippets. Prior, when the user submitted a blank catalog search, the entire indexed text will be returned. This is not desired because if we're looking at a book with a hundred pages, then that's a lot of rendered text. Instead, if we don't have a query string then we will also return.
|
Is it possible to hide the keyword label if there is nothing to show? Or do we always show the labels regardless? That looks a bit odd to me. |
|
@laritakr thanks for pointing that out, this led me down a different path and no changes should be needed in IIIF Print now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This commit will address blank catalog searches and how it interacts with snippets. Prior, when the user submitted a blank catalog search, the entire indexed text will be returned. This is not desired because if we're looking at a book with a hundred pages, then that's a lot of rendered text. Instead, if we don't have a query string then we will also return.
Expected Behavior Before Changes
Expected Behavior After Changes