Skip to content

Commit

Permalink
Get rubocop added in the app by adding gem, and by adding to CI. I ra…
Browse files Browse the repository at this point in the history
…n it locally and there are 303 offenses detected, 282 offenses autocorrectable, but that will go in another pr
  • Loading branch information
aprilrieger committed Oct 24, 2023
1 parent a8f9d1d commit 9ab692e
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build-test-lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ jobs:
# with:
# webTarget:

# lint:
# needs: build
# uses: scientist-softserv/actions/.github/workflows/[email protected]
# with:
# webTarget:
lint:
needs: build
uses: scientist-softserv/actions/.github/workflows/[email protected]
with:
webTarget: web
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,7 @@ group :development do
gem 'spring-watcher-listen', '~> 2.0.0'
end

gem 'rubocop'

# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
# gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
28 changes: 28 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,13 @@ GEM
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
ast (2.4.2)
async (2.6.2)
console (~> 1.10)
fiber-annotation
io-event (~> 1.1)
timers (~> 4.1)
base64 (0.1.1)
bootsnap (1.15.0)
msgpack (~> 1.2)
builder (3.2.4)
Expand Down Expand Up @@ -136,10 +138,12 @@ GEM
i18n (1.14.1)
concurrent-ruby (~> 1.0)
io-event (1.2.2)
json (2.6.3)
kaminari-core (1.2.2)
kaminari-grape (1.0.1)
grape
kaminari-core (~> 1.0)
language_server-protocol (3.17.0.3)
listen (3.7.1)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
Expand Down Expand Up @@ -183,6 +187,10 @@ GEM
pagy_cursor (0.6.0)
activerecord (>= 5)
pagy (>= 6, < 7)
parallel (1.23.0)
parser (3.2.2.4)
ast (~> 2.4.1)
racc
pg (1.4.5)
puma (6.0.1)
nio4r (~> 2.0)
Expand Down Expand Up @@ -223,16 +231,34 @@ GEM
rake (>= 12.2)
thor (~> 1.0)
zeitwerk (~> 2.5)
rainbow (3.1.1)
rake (13.0.6)
rb-fsevent (0.11.2)
rb-inotify (0.10.1)
ffi (~> 1.0)
regexp_parser (2.8.2)
representable (3.2.0)
declarative (< 0.1.0)
trailblazer-option (>= 0.1.1, < 0.2.0)
uber (< 0.2.0)
rexml (3.2.6)
roar (1.1.1)
representable (~> 3.0)
rubocop (1.57.1)
base64 (~> 0.1.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.2.2.4)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.28.1, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
ruby-progressbar (1.13.0)
ruby2_keywords (0.0.5)
slack-ruby-bot-server (2.1.0)
async
Expand Down Expand Up @@ -264,6 +290,7 @@ GEM
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
uber (0.1.0)
unicode-display_width (2.5.0)
websocket-driver (0.7.5)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
Expand All @@ -283,6 +310,7 @@ DEPENDENCIES
pg
puma (~> 6.0.1)
rails (~> 7.0.4)
rubocop
slack-ruby-bot-server-events
spring
spring-watcher-listen (~> 2.0.0)
Expand Down

0 comments on commit 9ab692e

Please sign in to comment.