Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA (BACKEND): Get a single remote authority working (Bulkrax) #212

Closed
ShanaLMoore opened this issue Nov 18, 2022 · 13 comments
Closed

QA (BACKEND): Get a single remote authority working (Bulkrax) #212

ShanaLMoore opened this issue Nov 18, 2022 · 13 comments

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Nov 18, 2022

Summary

Get a single remote authority working. Start with library of congress

Acceptance Criteria

Testing Instructions

Notes

Questioning Authority Gem

LOC (library of congress) QA docs

client's list: https://github.com/markpbaggett/cartography/blob/main/extras/vocabs.yml

@ShanaLMoore ShanaLMoore changed the title Get a single authority working Get a single remote authority working Nov 18, 2022
@ShanaLMoore ShanaLMoore self-assigned this Nov 18, 2022
@ShanaLMoore
Copy link
Contributor Author

@ShanaLMoore
Copy link
Contributor Author

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Nov 28, 2022

Example search subauthority subjects:

http://dev.utk-hyku.test/authorities/search/loc/subjects?q=History--

Image

@ShanaLMoore
Copy link
Contributor Author

@ShanaLMoore
Copy link
Contributor Author

qa removed lcsh authority because it duplicates LOC's subjects sub-authority

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Nov 29, 2022

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Dec 1, 2022

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Dec 5, 2022

This ticket needs to be broken down into multiple tickets. UI vs backend.

make factory pattern/single point of entry for the term - pass URL and get back relevant label. This will also make it easier to test

      # make RemoteAuthority module . Authority.label_for_url(url) -  check for where url is (local, db, remote)
      # will allow us to make submodules for each type (ie: geoname)
      # local caching can be done at the remoteAuthority level.
      # this separates frontend from backend. someone can handle frontend. someone else can handle adding more sub authorities.
      # with the argument passed we need to figure out where authority is (ask remote, db cache or local)
      # Break tickets down
      # UI/Indexing (label show on page (solr), editing should show label(fedora) )
      # caching as a different ticket?
      # BACKEND How is this done in questioning authority (remote interaction). get authority module working to return a string once passed a url
      # Insullation layer (=> create wrapper around calling gem directly. can help to protect us from being codependent on the gem)
      # do we can the label to be saved in fedora? 

      auth_id = Authority.sanitize_controlled_field_uri(value) # assume user-provided URI references a valid authority
      # fetch and cache authority (job) => background job to go to LOC and pull them into local db. Authority.fetch_cache_term

@ShanaLMoore ShanaLMoore changed the title Get a single remote authority working QA (BACKEND): Get a single remote authority working Dec 5, 2022
@ShanaLMoore ShanaLMoore changed the title QA (BACKEND): Get a single remote authority working QA (BACKEND): Get a single remote authority working (Bulkrax) Dec 5, 2022
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Dec 9, 2022

https://github.com/samvera/questioning_authority/wiki/Connecting-to-Library-of-Congress-%28LOC%29#accessing-via-qa

We need to implement vocabulary search with #find. this will be captured in a separate ticket.

@ShanaLMoore
Copy link
Contributor Author

PR started: #263

@laritakr
Copy link
Contributor

Another test comment for Shana

@ShanaLMoore
Copy link
Contributor Author

@ShanaLMoore ShanaLMoore removed their assignment Jan 10, 2023
@jillpe jillpe added this to the Digital Collections milestone Apr 20, 2023
@jillpe jillpe modified the milestones: Milestone 1, Milestone 4 May 11, 2023
@jillpe
Copy link

jillpe commented May 24, 2024

No longer necessary

@jillpe jillpe closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants