I251 subject search box #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
commented
Dec 2, 2022
| @@ -0,0 +1,24 @@ | |||
| url-pattern: | |||
There was a problem hiding this comment.
This file was produced by the generator. I am not sure how it gets used yet, but would prefer to keep it around for now to not forget about it later.
ShanaLMoore
commented
Dec 2, 2022
| @@ -0,0 +1,13 @@ | |||
| <%= f.input :subject, | |||
There was a problem hiding this comment.
This will eventually need to be dynamic (to work for any flex defined controlled value).
laritakr
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #251
This is the first PR of many. Step 1 of an epic. Most of the added files in here is from the QA (questioning authority) generator.
This only focuses on enabling library of congress search for the subject property.
On a work's form, the subject property will have a search box. Once the user starts typing, it queries library of congress and displays options that a user could select.
On save, the label will appear on the show page (not the id, which looks like a uri).