Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase counter before calling parse #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

increase counter before calling parse #8

wants to merge 1 commit into from

Conversation

archmoj
Copy link

@archmoj archmoj commented Apr 1, 2020

We sometimes get different inline numbers when building plotly.js for Chart Studio nodes.
cc: https://github.com/plotly/streambed/issues/13816
inline-diff.

This PR attempts to address this issue by increasing the global counter before calling time-consuming parse function.

@mikolalysenko

@archmoj
Copy link
Author

archmoj commented Apr 15, 2020

ping @mikolalysenko

@archmoj
Copy link
Author

archmoj commented Jun 10, 2020

cc: @rreusser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant