Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : flow plot bug on axis range for histplot and hist2dplot #432

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

Ming-Yan
Copy link
Contributor

change the axis range to fix the bug #431

@andrzejnovak
Copy link
Member

Thanks for the super quick fix. Should this affect the existing baseline images? Also could you add a quick test, based on the example in the issue? Perhaps using sth like @check_figures_equal instead of generating a new baseline image test like here:

@check_figures_equal()

@Ming-Yan
Copy link
Contributor Author

Indeed the split of the broken axis ticks slightly change in this PR. Regarding to the new test based on this issue, I am a bit confused what to compared in this test

@andrzejnovak
Copy link
Member

It could either be a simple test just checking if it executes correctly or with the check equal it could be comparing a hist 1 bin histogram to manually plotting histplot([1])

@Ming-Yan
Copy link
Contributor Author

Indeed I find out the plot could be very different due to the numpy hist not able to have flow bins. create new test with this issue
image

@andrzejnovak andrzejnovak merged commit 2aa455e into scikit-hep:master Jul 10, 2023
jonas-eschle pushed a commit that referenced this pull request Apr 22, 2024
* fix : flow plot bug on axis range for histplot and hist2dplot

* feat : add test for one bin hist with flow bins #431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants