-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overflow bug #437
fix: overflow bug #437
Conversation
Hi @Ming-Yan, thanks for the quick fix and sorry about the delay in taking a look. Could you double-check this and make sure we test across the matrix of options of the 4 flow parameters and different combinations of possible hist objects? I am currently getting a shape error with the following MRE
|
711138a
to
becf7cb
Compare
Hi @andrzejnovak , thanks for the feedback, indeed the padding |
Did the existing baseline images change? Perhaps the updated version is missing from the PR? |
I am a bit confused, the diff you linked seems to be for the flow test right? I'd expect the changes not affect the LHCb style here so if it's failing locally it shouldn't be an issue (you're probably missing msft fonts - LHCb uses Times New Roman). If it'd help, we're gonna drop python 3.7 anyway in #428 so I can merge that first if you'd want to rebase on that. |
Indeed the first plot(white background) is the local test, where no issue with flow plot but missing font in the machine. The second test is from the CI pipeline where the failure of
Yeah, I think this would be helpful🙂 |
alright, try now |
- remove overflow ticklabels - fix broken axis signs with correpsponding pending axis - fix binnings & pad nan for flow axis
Superseded in #487 |
Fix the bug mentioned in #436
Under/overflow bins define as non-zero value