Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plothist style #528

Merged
merged 5 commits into from
Oct 18, 2024
Merged

feat: add plothist style #528

merged 5 commits into from
Oct 18, 2024

Conversation

andrzejnovak
Copy link
Member

@jonas-eschle
Copy link
Contributor

Thanks for going forward with this! About the style name, isn't this maybe better to be named BelleII or similar?

@andrzejnovak
Copy link
Member Author

Yes, I would be in favour of naming it "Belle" which would be consistent with the rest of the styles and I assume safe wrt Belle vs Belle2 :) but I'd let @0ctagon and @cyrraz opine on that

@0ctagon
Copy link
Member

0ctagon commented Oct 18, 2024

I think we need:

  • The default style of plothist for the examples in the documentation, which we would call plothist for legacy or default, base, masterclass...
  • The default Belle II style, which by construction would be very similar to the current plothist style, that we would call Belle2. To push this into mplhep, I think we would need approval from the Belle II publication committee (and they might change the style a bit from plothist). I will look into this.
  • I have no idea about the Belle plot publishing guidelines, I will also look into this so we can add it.

@andrzejnovak
Copy link
Member Author

Well, let's put that in for now and we can revisit it / include dedicated Belle style later

@andrzejnovak andrzejnovak merged commit 6f4b23f into main Oct 18, 2024
12 checks passed
@andrzejnovak andrzejnovak deleted the phsty branch October 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants