Skip to content

Commit

Permalink
add additional todo comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kratsg committed Jun 26, 2024
1 parent 4412a76 commit 071c32a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/pyhf/optimize/mixins.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ def _internal_postprocess(
tensorlib, _ = get_backend()

# TODO: check how to handle this for batching

Check notice on line 89 in src/pyhf/optimize/mixins.py

View check run for this annotation

codefactor.io / CodeFactor

src/pyhf/optimize/mixins.py#L89

Unresolved comment '# TODO: check how to handle this for batching'. (C100)
# TODO: handle skipping fixed parameters

Check notice on line 90 in src/pyhf/optimize/mixins.py

View check run for this annotation

codefactor.io / CodeFactor

src/pyhf/optimize/mixins.py#L90

Unresolved comment '# TODO: handle skipping fixed parameters'. (C100)
# TODO: handle various backends

Check notice on line 91 in src/pyhf/optimize/mixins.py

View check run for this annotation

codefactor.io / CodeFactor

src/pyhf/optimize/mixins.py#L91

Unresolved comment '# TODO: handle various backends'. (C100)
for par_index, (fitted_par, bound) in enumerate(zip(fitresult.x, par_bounds)):
if fitted_par in bound:
log.warning(f'parameter at index {par_index} is at the bounds')
Expand Down

0 comments on commit 071c32a

Please sign in to comment.