-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow failing toys #2128
Draft
lukasheinrich
wants to merge
3
commits into
main
Choose a base branch
from
toy_handling_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Allow failing toys #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasheinrich
changed the title
[WIP] first attempt on toy handling
[WIP] feat: allow failing toys
Mar 3, 2023
matthewfeickert
changed the title
[WIP] feat: allow failing toys
feat: Allow failing toys
Mar 3, 2023
matthewfeickert
force-pushed
the
toy_handling_test
branch
from
April 1, 2023 20:10
691e807
to
64a741a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
==========================================
- Coverage 98.28% 97.82% -0.46%
==========================================
Files 69 69
Lines 4539 4555 +16
Branches 803 807 +4
==========================================
- Hits 4461 4456 -5
- Misses 45 62 +17
- Partials 33 37 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matthewfeickert
force-pushed
the
toy_handling_test
branch
from
April 7, 2023 06:17
64a741a
to
f93d811
Compare
matthewfeickert
force-pushed
the
toy_handling_test
branch
from
July 5, 2023 15:28
f93d811
to
e589871
Compare
matthewfeickert
force-pushed
the
toy_handling_test
branch
from
December 13, 2023 12:20
e589871
to
803b842
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
Changes the public API
experiment/atlas
Relevant to ATLAS's interests
feat/enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1427
I tried to implement some basic checks for handling toys as in Issue #1427
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: