-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use uv during Dockerfile build #2485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
added
chore
Other changes that don't modify src or test files
Docker
Involving Docker images or builds
need-to-backport
tmp label until can be backported to patch release branch
labels
May 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 69 69
Lines 4543 4543
Branches 804 804
=======================================
Hits 4462 4462
Misses 48 48
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Speed up the Dockerfile build by using uv to install all Python dependencies.
matthewfeickert
force-pushed
the
docker/use-uv
branch
from
May 25, 2024 20:38
b085dd8
to
5f472f4
Compare
@meeseeksdev backport to release/v0.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pyhf
that referenced
this pull request
May 30, 2024
matthewfeickert
removed
the
need-to-backport
tmp label until can be backported to patch release branch
label
May 30, 2024
matthewfeickert
added a commit
that referenced
this pull request
May 30, 2024
* Backport: - PR #2485 - PR #2486 - parts of PR #2461 --------- Co-authored-by: Matthew Feickert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: