Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add filterwarnings for jax.xla_computation DeprecationWarning #2523

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 20, 2024

Description

Add an ignore to filterwarnings to avoid a DeprecationWarning on jax.xla_computation in jax v0.4.30+.

DeprecationWarning: jax.xla_computation is deprecated. Please use the AOT APIs.

c.f. jax-ml/jax#21923

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add an ignore to filterwarnings to avoid a DeprecationWarning
  on jax.xla_computation in jax v0.4.30+.

  > DeprecationWarning: jax.xla_computation is deprecated.
  > Please use the AOT APIs.

   - c.f. https://github.com/google/jax/pull/21923

@matthewfeickert matthewfeickert added fix A bug fix need-to-backport tmp label until can be backported to patch release branch labels Jun 20, 2024
@matthewfeickert matthewfeickert self-assigned this Jun 20, 2024
* Add an ignore to filterwarnings to avoid a DeprecationWarning
  on jax.xla_computation in jax v0.4.30+.

  > DeprecationWarning: jax.xla_computation is deprecated.
  > Please use the AOT APIs.
@matthewfeickert matthewfeickert force-pushed the fix/add-filterwarning-for-xla-computation branch from b3004b2 to 53d1722 Compare June 20, 2024 04:04
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (997e5e5) to head (53d1722).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2523   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 7259d60 into main Jun 20, 2024
24 checks passed
@matthewfeickert matthewfeickert deleted the fix/add-filterwarning-for-xla-computation branch June 20, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant