Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 3.13 and some touchup #201

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Oct 7, 2024

Adding 3.13, some touchup, should be faster. One CI run per Python version.

Fixing CI in #202.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
Copy link
Member Author

henryiii commented Oct 8, 2024

@HDembinski, are you maintaining here, or do you need/want help? I believe this is the last package holding back adding Python 3.13 for the scikit-hep metapackage. Edit: Oh, I thought there were binary wheels for some reason - I think I'm getting it mixed up with pyhepmc. Might be able to go ahead, will try.

@HDembinski
Copy link
Member

I am maintaining and there used to be binary wheels, but I moved the compiled code into scipy.

@HDembinski HDembinski marked this pull request as ready for review October 8, 2024 21:31
@HDembinski
Copy link
Member

The failures are unrelated to this patch, just a DeprecationWarning. I am going to keep this open until this is fixed.

@henryiii
Copy link
Member Author

henryiii commented Oct 8, 2024

Fix in #202

@henryiii
Copy link
Member Author

henryiii commented Oct 8, 2024

Ah, so it used to compile wheels, maybe that’s why I was confused. It’s probably not a blocker, then, though it would be nice to have the 3.13 classifier on everything ensure that everything is ready. (pylhe also doesn’t have a release with the classifier yet, though it’s in main). We don’t have very much testing for the scikit-hep metapackage to verify it all works.

@HDembinski HDembinski merged commit be3d5c1 into scikit-hep:main Oct 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants