Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove hyphens from test names (PyCharm compatibility) #1053

Merged
merged 1 commit into from
Dec 6, 2023
Merged

test: remove hyphens from test names (PyCharm compatibility) #1053

merged 1 commit into from
Dec 6, 2023

Conversation

lobis
Copy link
Collaborator

@lobis lobis commented Dec 5, 2023

This PR closes #970.

@lobis lobis added the tests More or better tests are needed label Dec 5, 2023
@lobis lobis linked an issue Dec 5, 2023 that may be closed by this pull request
test: remove hyphens from test file names #970
Closed
@lobis lobis requested review from agoose77 and jpivarski December 5, 2023 23:19
@lobis lobis marked this pull request as ready for review December 5, 2023 23:20
jpivarski
jpivarski approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it. I was planning on doing this right after #943.

Go ahead and merge!

@lobis lobis merged commit 8fd7985 into main Dec 6, 2023
20 checks passed
@lobis lobis deleted the 970-test-remove-hyphens-from-test-file-names branch December 6, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

@agoose77 agoose77 Awaiting requested review from agoose77

Assignees
No one assigned
Labels
tests More or better tests are needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: remove hyphens from test file names
2 participants
@lobis @jpivarski