-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Python 3.8, ensure Python 3.13 is included #1332
Conversation
There's a bit of clean up that can be done here. uproot5/src/uproot/source/fsspec.py Lines 136 to 153 in a331467
I'm not sure if it would be better to do it here or in another PR. |
If that section of code can be cleaned up because we aren't supporting Python 3.8 anymore, then it makes sense to include it in this PR. I think you have write access to this PR, so go ahead and do what you think should be done. I won't merge it until you say you're done. |
Yeah, Python 3.9 introduced I tried to find other potential cleanups, but I think that was the only one. |
I fixed the tests that were failing. I introduced a fix for numpy v1, but I think it's small enough that it should be fine to include in here. It should now be good to go, at least from my side. |
This looks great; thank you! I can't approve it as a PR because I started it, but I approve anyway. Since you're done, I'll merge it and make Uproot 5.5.0. (I just checked to see if any tests need to be added to the branch protection—no, thanks to the DAG that ends in a test called "Pass", we can change which tests run and still have them all be required now.) |
No description provided.