-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't assume Uproot is in global scope in TPython::Eval #927
fix: don't assume Uproot is in global scope in TPython::Eval #927
Conversation
Let me know, @mramospe and @franciscosili, if this PR fixes the issue in your context. As you can see above, I wasn't able to reproduce it. |
I can't reproduce with your test, but this one works for me # BSD 3-Clause License; see https://github.com/scikit-hep/uproot5/blob/main/LICENSE
import ROOT
def test_import():
h = ROOT.TProfile3D()
__import__("uproot").from_pyroot(h) |
I verified that TProfile3D raises a segfault in uproot5/src/uproot/behaviors/TH3.py Lines 4 to 5 in a8644df
Well, this does verify that there's a segfault without the fix and no segfault with the fix, so I'll ask @ioanaif to review this PR and merge it if everything's good. (I'm not planning on making any more changes.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Works for me now. Thanks a lot! |
The test for this now breaks; see issue #1237. |
No description provided.