-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for check_cv method with and without random_state #337
Add tests for check_cv method with and without random_state #337
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 4278 4303 +25
Branches 467 474 +7
=========================================
+ Hits 4278 4303 +25
☔ View full report in Codecov by Sentry. |
…n-not-seeded-implies-wrong-prediction-intervals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fixes the problem. I just think some small details need to be added.
Description
The modification proposes to resolve the bug by imposing a default value for random_state in check_cv method tests, so that the method retains split behavior even if random_state is set to None.
Fixes #336
Type of change
How Has This Been Tested?
Checklist
make lint
make type-check
make tests
make coverage
make doc