Fix pl plotting #55
Merged
Fix pl plotting #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous label keyword had no effect; this fixes that and adds doc string entries for labels.
The tick marks on the y-axis (corresponding to depth of the landscapes) were completely off and mislabeled.
The new 'depth_range' parameter allows the user to specify a range of depths to be plotted. Omitting it plots all depths.
The doc strings were previously in the helper functions, which were not publicly accessible. Move the docstrings into the two main plotting functions and clean up the signatures of the plotting functions.
The previous way of padding the figures changed their values slightly. The 'padding' parameter now adds a slight margin to the plot, especially useful for 2-d 'simple' plots.
`depth_spacing` caused overcrowding issues with labelling. If it needs to be modified, it should be done on a case by case basis by passing an axis.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 75.84% 74.52% -1.32%
==========================================
Files 20 20
Lines 1453 1480 +27
Branches 315 327 +12
==========================================
+ Hits 1102 1103 +1
- Misses 293 319 +26
Partials 58 58 ☔ View full report in Codecov by Sentry. |
|
Hi @catanzaromj, these changes look great. Once the tests are passing we can merge. Though it looks like the test failure might be unrelated, you should be able to fix it using Thank you! |
|
@sauln No problem. Let me know if there's anything else. Thanks! |
|
@sauln Is there anything else needed? |
|
The test coverage dropping will be covered in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes numerous bugs with plotting persistence landscapes. In particular
depth_rangeparameter so a subset of landscape functions can be plotted,paddingpreviously incorrectly changed landscape function values,A
max_depthattribute has also been added toPersLandscapeApproxand the notebooks were updated.Please pass along any comments you have. Thanks.