Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken machine learning notebook #78

Merged

Conversation

catanzaromj
Copy link
Contributor

@catanzaromj catanzaromj commented Mar 6, 2024

This PR fixes the Persistence Landscapes and Machine Learning notebook that broke in a previous merge. Raised in #77

@catanzaromj catanzaromj added the bug Something isn't working label Mar 6, 2024
@catanzaromj catanzaromj self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (71187b2) to head (88e9184).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files          20       20           
  Lines        1486     1486           
  Branches      327      327           
=======================================
  Hits         1180     1180           
  Misses        228      228           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@catanzaromj catanzaromj linked an issue Mar 6, 2024 that may be closed by this pull request
@catanzaromj catanzaromj marked this pull request as ready for review March 6, 2024 13:29
@catanzaromj catanzaromj merged commit a44f6eb into scikit-tda:master Mar 6, 2024
9 checks passed
@catanzaromj catanzaromj deleted the broken_machine_learning_notebook branch March 6, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistence Landscapes and Machine Learning notebook issue
1 participant