-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Update registration subworkflows and modules #25
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs some consistency with version. Sometimes Freesurfer 7.4 / 7.4.1
Is there a way to extract version from one bin instead of hardcoded it ?
There is a version flag for |
In this case, in the case of synthregistration, there is an official synthmorph only container, therefore not allowing to extract version with mri_convert. But synthmorph:3, which we use here, starts at freesurfer:7.4.1 (i believe, but not 100% ure) |
ebc8cb5
to
402c147
Compare
b559689
to
659a2f0
Compare
Type of improvement
Describe your improvement
subworkflow/registration:
modules/synthregistration:
module/convert:
Checklist before requesting a review