Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update registration subworkflows and modules #25

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Oct 29, 2024

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

subworkflow/registration:

  • add synthregistration optionality to subworkflow
  • add specific test for synthregistration

modules/synthregistration:

  • change output structure to tuple transfo_image containing both transforms
  • add python package access.

module/convert:

  • add optionality to affine conversion. If no affine is provided, skips conversion. Synthmorph output include affine initialization in its deform output.
  • change output order

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

arnaudbore
arnaudbore previously approved these changes Oct 30, 2024
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs some consistency with version. Sometimes Freesurfer 7.4 / 7.4.1
Is there a way to extract version from one bin instead of hardcoded it ?

@gagnonanthony
Copy link
Contributor

There is a version flag for mri_convert, we could use it like this to fetch freesurfer's version: mri_convert -version | grep "freesurfer" | sed -E 's/.* ([0-9]+\\.[0-9]+\\.[0-9]+).*/\\1/' @anroy1 @arnaudbore

@anroy1
Copy link
Contributor Author

anroy1 commented Oct 30, 2024

In this case, in the case of synthregistration, there is an official synthmorph only container, therefore not allowing to extract version with mri_convert. But synthmorph:3, which we use here, starts at freesurfer:7.4.1 (i believe, but not 100% ure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants