-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module to burn voxels #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things to discussed but it should be merged by the end of the day easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Filling your PR description
New module to burn an image with multiple masks.
List test packages used by your module
tractometry.zip
Checklist before requesting a review
./modules/nf-neuro/<category>/<tool>/main.nf
./modules/nf-neuro/<category>/<tool>/meta.yml
./modules/nf-neuro/<category>/<tool>/environment.yml
./modules/nf-neuro/<category>/<tool>/tests/main.nf.test
main.nf.test.snap
snapshotsprettier
andeditorconfig-checker
to fix common syntax issuesnf-core modules lint
and fix all errors