Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module to burn voxels #27

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Conversation

GuillaumeTh
Copy link
Contributor

@GuillaumeTh GuillaumeTh commented Oct 29, 2024

Filling your PR description

New module to burn an image with multiple masks.

List test packages used by your module

tractometry.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-neuro/<category>/<tool>/main.nf
    • Edit ./modules/nf-neuro/<category>/<tool>/meta.yml
    • Edit ./modules/nf-neuro/<category>/<tool>/environment.yml
  • Generate the tests:
    • Edit ./modules/nf-neuro/<category>/<tool>/tests/main.nf.test
    • Run the tests to generate the main.nf.test.snap snapshots
  • Ensure the syntax is correct :
    • Run prettier and editorconfig-checker to fix common syntax issues
    • Run nf-core modules lint and fix all errors
    • Ensure your variables have good, clear names

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to discussed but it should be merged by the end of the day easily.

modules/nf-neuro/image/burnvoxels/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-neuro/image/burnvoxels/tests/main.nf.test.snap Outdated Show resolved Hide resolved
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but otherwise looks great!

modules/nf-neuro/image/burnvoxels/main.nf Show resolved Hide resolved
modules/nf-neuro/image/burnvoxels/meta.yml Show resolved Hide resolved
modules/nf-neuro/image/burnvoxels/meta.yml Outdated Show resolved Hide resolved
gagnonanthony
gagnonanthony previously approved these changes Oct 30, 2024
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnaudbore arnaudbore merged commit 645e64e into scilus:main Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants