Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] update preproc module #36

Merged
merged 1 commit into from
Nov 2, 2024
Merged

[ENH] update preproc module #36

merged 1 commit into from
Nov 2, 2024

Conversation

arnaudbore
Copy link
Contributor

Type of improvement

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Update preproc modules with Alex's changes + update tests. #14

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

@arnaudbore arnaudbore requested review from gagnonanthony and ThoumyreStanislas and removed request for AlexVCaron and Manonedde November 1, 2024 18:48
ThoumyreStanislas
ThoumyreStanislas approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@ThoumyreStanislas ThoumyreStanislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great PR!

@arnaudbore
Copy link
Contributor Author

It will close #31

gagnonanthony
gagnonanthony approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insane PR! 💯

@arnaudbore arnaudbore added this pull request to the merge queue Nov 2, 2024
Merged via the queue into scilus:main with commit 7662adb Nov 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagnonanthony gagnonanthony gagnonanthony approved these changes

@ThoumyreStanislas ThoumyreStanislas ThoumyreStanislas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaudbore @gagnonanthony @ThoumyreStanislas