Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New module] Freesurfer registration/convert #5

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Sep 24, 2024

Describe your changes

Add the synthbet option to preproc_t1Warp conversion module - designed initially to convert freesurfer registration warp (affine and deform) to ants-itk. Then decided to generalize the module for all cases possible. Receives one affine matrix, one deform warp, source and target images for orientation (and freesurfer licence) and outputs converted affine and deform.

List test packages used by your module

  • freeurfer.zip
  • freesurfer_relice.zip
  • freesurfer_transforms.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

To Do

Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, all functionalities are there ! There is a little work to be done on syntax. To be consistent, you should stick with a naming convention. Either use affine or linear everywhere when you are talking about the affine/linear part, and drop init when talking about the input or output transforms.

Once adressed, LGTM !

modules/nf-neuro/registration/convert/environment.yml Outdated Show resolved Hide resolved
modules/nf-neuro/registration/convert/main.nf Outdated Show resolved Hide resolved
@AlexVCaron AlexVCaron mentioned this pull request Sep 24, 2024
8 tasks
@AlexVCaron AlexVCaron removed the request for review from Manonedde September 24, 2024 18:22
@arnaudbore arnaudbore self-requested a review September 24, 2024 23:36
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

modules/nf-neuro/registration/convert/main.nf Show resolved Hide resolved
@AlexVCaron
Copy link
Collaborator

Great job @anroy1 ! LGTM 🚀

@AlexVCaron AlexVCaron added this pull request to the merge queue Sep 25, 2024
Merged via the queue into scilus:main with commit c463eff Sep 25, 2024
10 checks passed
@anroy1 anroy1 deleted the warpconvert branch September 27, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants