-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] add synthseg option to anatomical_segmentation #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again with the syntax, all code functionnalities seem to be there ! It's going to be merged fast !
subworkflows/nf-neuro/anatomical_segmentation/tests/nextflow_synthseg.config
Show resolved
Hide resolved
08755cd
to
eebe069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a comment that should get you out of the process killing. Another one we should discuss live 😉
subworkflows/nf-neuro/anatomical_segmentation/tests/nextflow_synthseg.config
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have yet to run the tests and check the meta, but this first comment should help you move along a bit.
e0a333a
to
ec4d8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got some comments, but they are minor. Once addressed, we can focus on making the runners abide by the tests 😂 we're almost there, I believe the next problems we'll hit will be resources, then that's it ! Hopefully 🍀
After considerations, you won't attain reproducibility. Defer to using only the names in all use-cases involving synthseg |
5e8a3c6
to
7c35b17
Compare
7c35b17
to
5886e9c
Compare
Describe your changes
Add the synthseg option to anatomical_segmentation
List test packages used by your module
T1w.zip
freesurfer_nifti.zip
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config
To Do
Pass synthseg module to run and debug tests