Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] add synthseg option to anatomical_segmentation #9

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Sep 24, 2024

Describe your changes

Add the synthseg option to anatomical_segmentation

List test packages used by your module

  • T1w.zip
  • freesurfer_nifti.zip

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

To Do

Pass synthseg module to run and debug tests

Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again with the syntax, all code functionnalities seem to be there ! It's going to be merged fast !

@anroy1 anroy1 force-pushed the subflow-synthseg branch 2 times, most recently from 08755cd to eebe069 Compare October 1, 2024 18:03
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment that should get you out of the process killing. Another one we should discuss live 😉

Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have yet to run the tests and check the meta, but this first comment should help you move along a bit.

subworkflows/nf-neuro/anatomical_segmentation/main.nf Outdated Show resolved Hide resolved
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some comments, but they are minor. Once addressed, we can focus on making the runners abide by the tests 😂 we're almost there, I believe the next problems we'll hit will be resources, then that's it ! Hopefully 🍀

@AlexVCaron
Copy link
Collaborator

After considerations, you won't attain reproducibility. Defer to using only the names in all use-cases involving synthseg

@anroy1 anroy1 force-pushed the subflow-synthseg branch 2 times, most recently from 5e8a3c6 to 7c35b17 Compare October 14, 2024 15:34
@AlexVCaron AlexVCaron added this pull request to the merge queue Oct 15, 2024
Merged via the queue into scilus:main with commit 719cb46 Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants