-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Subworkflow][WIP] Tractoflow #177
Open
AlexVCaron
wants to merge
19
commits into
main
Choose a base branch
from
feat/tractoflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVCaron
force-pushed
the
feat/tractoflow
branch
from
July 26, 2024 20:02
9ddee34
to
b17ae8e
Compare
…much test packages to try further accelerate tests.
…t. Takes 10 minutes on 20 slices, but oh well, what can you ask from ants.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Subworkflow for Tractoflow here ! In addition there is also some changes to modules and subworkflows it depends on :
if/else
by clever uses of.join()
withremainder: true
20 axial slices subject
(newly created for Tractoflow, but we should use it everywhere)The subworkflow does not include reading inputs from bids or other sources. For this, I'd rather we have another subworkflow doing the job.
The PR is quite big and could be chunked to single out individual module or subworkflow updates. We'll also see after the PR opens if the test infra responds well.
List test packages used by your module
Everything used by modules in nf-scil
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config