Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Prettier inside the devcontainer doesn't work #199

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

AlexVCaron
Copy link
Collaborator

Bug category

  • Critical (some functionalities is not working at all)
  • Major (something is not working as expected)
  • Minor (something but could be improved)
  • Trivial (documentation needs correcting and other non-functional issues)

Describe the bug

Prettier is not running inside of the container. In fact, the whole settings section in the devcontainer.json file wasn't applied. This fixes it all.

Steps to reproduce the bug

A. On the main branch

  1. Delete the node_modules folder in the workspace if present.
  2. Rebuild the container
  3. Open any .nf file, the icon for prettier in the lower right corner should be red, indicating prettier is bugged
    B. On this PR
  4. Rebuild the container
  5. Open any .nf file, the icon for prettier in the lower right corner should be gray, with two check marks

@AlexVCaron AlexVCaron changed the title fix devcontainer settings [FIX] Prettier inside the devcontainer doesn't work Sep 6, 2024
@AlexVCaron AlexVCaron added this pull request to the merge queue Sep 6, 2024
Merged via the queue into scilus:main with commit 129a88e Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant