[WIP] add t1 option in fslbetcrop module #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
AlexVCaron
requested changes
Feb 23, 2024
There was a problem hiding this comment.
This is on the right path, very good job 🚀 However, looking at the current tractoflow, there is a few more options to add as well for it to fit the use-case. We need to have a chat about it, because looking at the current structure, you'll end up adding imbricated if/else blocks, and I don't want that.
gagnonanthony
requested changes
Feb 26, 2024
Closed
|
@AlexVCaron for the moment the script works in this form but the nomenclature is not optimal. There are too many "image" files but I'm having trouble finding a good way to change that. |
AlexVCaron
requested changes
Feb 27, 2024
gagnonanthony
requested changes
Feb 28, 2024
AlexVCaron
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the option for a fsl bet / crop on a T1 images and create the test with Scilpy Fetcher