[ENH] update to scilpy 2 #31
Open
+67
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
I ran it with 3 subjects, each with slightly differents bundles (to look at missing data), the third subject had 1 metric instead of 2, 2 subjects had lesions and not the other. Everything came out as expected except 1 thing: scil_lesions_info.py was doing the labelling (from binary mask to counting lesions) and now we need to use scil_labels_from_mask.py before the for loop and call scil_lesions_info.py with that new labels file. That's all I think ! |
|
Tested on new data, mixed up input a bit and its all good ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs some update from scilpy 2 to make it work especially stats have grown up but scil_json_convert_entries_to_xlsx.py has not.
Fix #25