Serial em #31
Open
Serial em #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check the 7 issues marked by Sonar Cloud. |
|
Also, please complete the help in the protocol form for the parameters (i.e. maxFrameShift, maxDefocusU, ...) with units and explanations. |
danielmarchan3
requested changes
Apr 22, 2024
# Conflicts: # emfacilities/protocols/protocol_monitor_serialem.py
|
albertmena
reviewed
Nov 25, 2024
| STATUS_STOP = [STATUS_FINISHED, STATUS_FAILED, STATUS_ABORTED] | ||
|
|
||
| class ProtMonitorSerialEm(ProtMonitor): | ||
| """ Stores values for SerialEM to read , |
There was a problem hiding this comment.
Be more verbose to explain what this protocol does
|
@danielmarchan3 How is this PR? need a second review? works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functionality of serialEM that creates a file with the required parameters to be able to change values inside SerialEM reading from the created file by scipion (the calculation of the values are inside another box from scipion to prevent bugs in another functionalities thus isolating it)