Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Readthedocs and Sphinx #890

Merged
merged 32 commits into from
Sep 7, 2024
Merged

Migrate to Readthedocs and Sphinx #890

merged 32 commits into from
Sep 7, 2024

Conversation

Opt-Mucca
Copy link
Collaborator

This change moves our documentation from GitHub to Readthedocs.
I've added a basic structure / install guides / introduction to most plug-ins / motivation for using SCIP / FAQ / API reference manual.
I've also added a few new wrapper functions. These were needed when implementing the new examples in the documentation that are now duplicated as tests.

After this gets merged we'd need to do the following:

  • Make a readthedocs account for pyscipopt
  • Link it to the GitHub
  • Update the README and INSTALL

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 54.23%. Comparing base (23e00b3) to head (a9b494b).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
src/pyscipopt/scip.pxi 48.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
+ Coverage   52.29%   54.23%   +1.93%     
==========================================
  Files          20       20              
  Lines        3991     4326     +335     
==========================================
+ Hits         2087     2346     +259     
- Misses       1904     1980      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joao-Dionisio
Copy link
Collaborator

You already know I find this absolutely incredible, Mark, and we discussed reviewing these things after merging. So on my end, we're good to go!

@Joao-Dionisio Joao-Dionisio enabled auto-merge (squash) September 6, 2024 15:01
@Opt-Mucca
Copy link
Collaborator Author

@Joao-Dionisio thank you! I am extremely happy with the outcome of this. (you have to actually approve the MR which I always forget to do)

@Joao-Dionisio Joao-Dionisio merged commit 85086fa into master Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants