solve problem with multi-threads #918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. solveFirstInterruptOthers 3. add copy model method 4. add copy model solution 5. add some Solution methods
Opt-Mucca
reviewed
Oct 28, 2024
tests/test_multi_threads.py
Outdated
| for i in range(N_Threads): | ||
| models[i].setParam("randomization/permutationseed", i) | ||
|
|
||
| ori_model.optimize() |
There was a problem hiding this comment.
Why does this optimize call need to come before the others are called?
There was a problem hiding this comment.
ori_model.optimize() can be called anywhere.
It's ok before or after ori_model.copyModel(), models[i].setParam("randomization/permutationseed", i), Model.solveFirstInterruptOthers(executor=executor, models=models)
|
Thanks for the PR @liangbug !
|
Appendix 1. from pyscipopt import Model
def main():
orig_scip = Model()
copy_scip = Model.copyModel(orig_scip)
new_scip = Model(sourceModel=orig_scip)
orig_scip_param_names = orig_scip.getParams().keys()
copy_scip_param_names = copy_scip.getParams().keys()
new_scip_param_names = new_scip.getParams().keys()
lost_params = sorted(list(set(orig_scip_param_names) - set(new_scip_param_names)))
print('The count of orig scip params:', len(orig_scip_param_names))
print('The count of copy scip params:', len(copy_scip_param_names))
print('The count of new scip params:', len(new_scip_param_names))
print('The lost of new scip params:', lost_params)
if __name__ == "__main__":
main() |
|
Hey @liangbug! Last week, @Opt-Mucca, @mmghannam, and I discussed this PR and came to the following conclusions.
However, we understand the frustration with using What do you think of this, @liangbug? Does it sound reasonable? |
|
I understand yours concerns. |
2. model addOrigVarsConssObjectiveFrom 3. add some Solution methods
|
Hi @Opt-Mucca @Joao-Dionisio
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to solve problem with multi-threads and different random seeds
So I added some methods including
The copyed model from init method argument sourceModel loses some scip components.
The new copy model method use full scip components.