MAINT: Adapt to NumPy 2.0 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There will be more of these. Will be easier to smoke them out when there is a numpy-2.0 compatible scipy build |
|
The lack of numpy 2.0 compatible matplotlib is a blocker. Self-tests pass when skipping MPL (cross-ref gh-131) though. FWIW. |
In that MPL version (numpy 2.0 compatible?), the text of the user warning has changed into UserWarning: FigureCanvasAgg is non-interactive, and thus cannot be shown
|
OK, run tests locally with numpy 2.0 and MPL 3.8.3. The only fix here was to adjust the MPL filter for the display-less backend. SciPy branch had to adjust a bit to the numpy 2.0 scalar repr, the main one is gh-147. |
ev-br
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise self-tests simply hang: np.VisibleDeprecatinWarning is not found at https://github.com/ev-br/scpdt/blob/main/scpdt/impl.py#L254, so we get into the
except Exception:branch and it all goes downhill from there.cross-ref #79 (comment)