116 hackathon rkvst implementation #28
Conversation
…ITT service Signed-off-by: JAG-UK <[email protected]>
Signed-off-by: JAG-UK <[email protected]>
JAG-UK
requested review from
letmaik,
mprorock,
SteveLasker,
OR13 and
henkbirkholz
Signed-off-by: JAG-UK <[email protected]>
Signed-off-by: JAG-UK <[email protected]>
Signed-off-by: JAG-UK <[email protected]>
Signed-off-by: JAG-UK <[email protected]>
Signed-off-by: JAG-UK <[email protected]>
Signed-off-by: JAG-UK <[email protected]>
Signed-off-by: JAG-UK <[email protected]>
| from pathlib import Path | ||
| import json | ||
| import cbor2 | ||
| #from cose.messages import CoseMessage |
|
|
||
| # Grab credentials from the enviroment | ||
| # TODO: we should support container storage and protected local file storage too | ||
| # TODO: we shold support unauthenticated connections for public read calls |
There was a problem hiding this comment.
I had similar question, it seems like all api operations probably want some access control.
There was a problem hiding this comment.
Doing something sophisticated here needs resolution on the Registration Policies and Identifiers discussions I think. The signer of the Signed Statement is not necessarily the caller of the API (in fact, will never be in my book, otherwise you'll be reusing keys in a naughty way ;-) so there's some unpicking to do here.
But yes at the moment all API calls do have authentication on them. My comment is that I think certain things could be relaxed in future when more of the API and surrounding concepts are fleshed out.
| #rkvst_receipt = rkvst_mocks.mock_receipt | ||
|
|
||
| # TODO: This is just neat debug. Get the JSON form of the receipt | ||
| receipt_file_path = f'{entry_id}.receipt.json' |
There was a problem hiding this comment.
we should really document a json form for them, we do something similar
There was a problem hiding this comment.
Happy to contribute this. Where do you think we should put it? I'd imagine just a subsection the API portion of the architecture doc.
Working RKVST back end implementation from 116 Hackathon, updated and works on free production SaaS.