Fix Werkzeug dependency for testing with Anaconda Python distribution #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to fix scitt-community#38, we need to hard pin the version of Werkzeug used by Flask to avoid the changes after to how functions are organized in the library's modules. See PR Sanster/IOPaint#390 with a related solution (not specific to Anaconda approach, but informative). See [StackOverflow](https://stackoverflow.com/a/77217971) post for details.
|
@pdxjohnny I tested this a few times against your branch and then rebased against main. I am pointing this at main so you can update/rebase the target branch in #39 and it should work. It won't work for other PR (the stack trace is reporting an unrelated problem from what I can tell), but I can review and assist on that as needed. Let me know. |
OR13
approved these changes
Nov 22, 2023
|
Thank you @aj-stein-nist for figuring this out! Turned out to be that |
|
Thanks, @aj-stein-nist, @pdxjohnny for figuring out this annoying issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38.