Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCITT Usage Examples #46

Merged
merged 27 commits into from
Oct 9, 2023
Merged

SCITT Usage Examples #46

merged 27 commits into from
Oct 9, 2023

Conversation

SteveLasker
Copy link
Collaborator

The beginning of a collection of use cases, with examples how SCITT is used to support them.

The first one captures the binary use case, where multiple versions are concurrently supported.
How would a SCITT Feed support this scenario?

Addresses: Refine Definition of Feed #11

@SteveLasker
Update README.md
f137968 
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker
Merge branch 'ietf-scitt:main' into main
e867863
@SteveLasker
Merge branch 'ietf-scitt:main' into main
0047a2a
@SteveLasker
Update _config.yml
f44250b 
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker
Merge branch 'ietf-scitt:main' into main
b3d9da1
@SteveLasker
Merge branch 'scitt-community:main' into main
c8815dc
@SteveLasker
Add examples for implementing the SCITT use cases
c8ebbbb 
Signed-off-by: steve lasker <[email protected]>
@SteveLasker
Add the binary use case outlining SCITT Feed scenarios
5852117 
Signed-off-by: steve lasker <[email protected]>
@SteveLasker
Update readme to reference the example usecase
2b4c860 
Signed-off-by: steve lasker <[email protected]>
@SteveLasker
revert _config.yml change
2b80c7c 
Signed-off-by: steve lasker <[email protected]>
@SteveLasker
revert _config.yml change
110dcee 
Signed-off-by: steve lasker <[email protected]>
@SteveLasker
Mmarkdown linting cleanup
2eaafef 
Signed-off-by: steve lasker <[email protected]>
JAG-UK
JAG-UK reviewed Sep 25, 2023
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
examples/feed-binary-usecase.md Outdated Show resolved Hide resolved
examples/feed-binary-usecase.md Outdated Show resolved Hide resolved
SteveLasker and others added 4 commits September 25, 2023 22:12
@SteveLasker @JAG-UK
Update examples/README.md
a8c0dfe 
Co-authored-by: Jon Geater <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker @JAG-UK
Update examples/feed-binary-usecase.md
1d355f9 
Co-authored-by: Jon Geater <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker @JAG-UK
Update examples/feed-binary-usecase.md
8950065 
Co-authored-by: Jon Geater <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker
Typo fix
74d6f70 
Signed-off-by: steve lasker <[email protected]>
henkbirkholz
henkbirkholz reviewed Sep 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
henkbirkholz
henkbirkholz reviewed Sep 26, 2023
View reviewed changes
_config.yml Outdated Show resolved Hide resolved
@SteveLasker
fix missing link
f067dc6 
Signed-off-by: steve lasker <[email protected]>
aj-stein-nist
aj-stein-nist reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am a recent lurker in this area. I have only minor feedback about typos and such things, I hope this is helpful.

examples/fictitious-companies.md Outdated Show resolved Hide resolved
examples/fictitious-companies.md Outdated Show resolved Hide resolved
examples/feed-binary-usecase.md Outdated Show resolved Hide resolved
SteveLasker and others added 3 commits September 30, 2023 08:08
@SteveLasker @aj-stein-nist
Update examples/fictitious-companies.md
f6ff9b5 
Co-authored-by: A.J. Stein <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker @aj-stein-nist
Update examples/fictitious-companies.md
07d5f98 
Co-authored-by: A.J. Stein <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker @aj-stein-nist
Update examples/feed-binary-usecase.md
09cefa1 
Co-authored-by: A.J. Stein <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker
Copy link
Collaborator Author

Thanks @aj-stein-nist for the feedback and your time.

@SteveLasker
Ordering of docs
cc99808 
Signed-off-by: steve lasker <[email protected]>
OR13
OR13 requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteveLasker please merge or dismiss @henkbirkholz 's suggestions, then I will approve again.

SteveLasker and others added 3 commits October 9, 2023 10:07
@SteveLasker @henkbirkholz
Update examples/feed-basic-example.md
0ab33d2 
Co-authored-by: Henk Birkholz <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker @henkbirkholz
Update examples/feed-basic-example.md
b784889 
Co-authored-by: Henk Birkholz <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker @henkbirkholz
Apply suggestions from code review
6e59a06 
Co-authored-by: Henk Birkholz <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
@SteveLasker
Copy link
Collaborator Author

@SteveLasker please merge or dismiss @henkbirkholz 's suggestions, then I will approve again.

Thanks, @OR13, merged the actionable ones, and replied to the questions.

@OR13 OR13 self-requested a review October 9, 2023 17:53
OR13
OR13 requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed again, there seems to be confusion regarding mangement of this repo, vs iETF work items, code owners have the ability to merge PRs here, IETF consenus is not required.

I'd like to see mandatory reviews from code owners, and I will approve after all threads are marked resolved.

@OR13 OR13 mentioned this pull request Oct 9, 2023
Open
@SteveLasker
Copy link
Collaborator Author

I reviewed again, there seems to be confusion regarding mangement of this repo, vs iETF work items, code owners have the ability to merge PRs here, IETF consenus is not required.

Correct, this is the SCITT Community, which supports the IETF SCITT specs, but is a more diverse group.
See SCITT Community

@SteveLasker SteveLasker merged commit 6972941 into scitt-community:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OR13 OR13 OR13 approved these changes

@henkbirkholz henkbirkholz henkbirkholz left review comments

@aj-stein-nist aj-stein-nist aj-stein-nist left review comments

@JAG-UK JAG-UK Awaiting requested review from JAG-UK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SteveLasker @OR13 @henkbirkholz @JAG-UK @aj-stein-nist