-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for env var replacement #19
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
## Placeholder for script that would be executed before running container | ||
## To replace this file you should create ./bin/init_script in your s2i context folder. See: `--context-dir` option. | ||
|
||
## This file can be used to inject environment variables into the configuration files | ||
|
||
## Setup default DNS_SERVER for proxy requests | ||
setup_dns_env_var() { | ||
if [ -z "$DNS_SERVER" ]; then | ||
export DNS_SERVER=`cat /etc/resolv.conf | grep "nameserver" | awk '{print $2}' | tr '\n' ' '` | ||
echo "Using system dns server ${DNS_SERVER}" | ||
else | ||
echo "Using user defined dns server: ${DNS_SERVER}" | ||
fi | ||
} | ||
|
||
## Inject environment variables | ||
inject_env_vars() { | ||
## Replace only specified environment variables in specified file. | ||
envsubst '${DNS_SERVER} | ||
${LOG_LEVEL}' < "${NGINX_CONFIGURATION_PATH}/$1" > "${NGINX_CONFIGURATION_PATH}/$1" | ||
} | ||
|
||
# setup_dns_env_var | ||
# inject_env_vars "default.conf" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
#!/bin/bash | ||
|
||
source /opt/app-root/etc/generate_container_user | ||
source $PRE_RUN_SCRIPT | ||
|
||
set -e | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
setup_dns_env_var() { | ||
if [ -z "$DNS_SERVER" ]; then | ||
export DNS_SERVER=`cat /etc/resolv.conf | grep "nameserver" | awk '{print $2}' | tr '\n' ' '` | ||
echo "Using system dns server ${DNS_SERVER}" | ||
else | ||
echo "Using user defined dns server: ${DNS_SERVER}" | ||
fi | ||
} | ||
|
||
inject_env_vars() { | ||
## Replace only specified environment variables in specified file. | ||
envsubst '${DNS_SERVER} | ||
${INDEX_FILE}' < "${NGINX_CONFIGURATION_PATH}/$1" > "${NGINX_CONFIGURATION_PATH}/$1" | ||
} | ||
|
||
export INDEX_FILE=index2.html | ||
setup_dns_env_var | ||
inject_env_vars "default.conf" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wtrocki Is 777 necessary? It is very open...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to change configuration in running container we would need to have write access to config for default user. Files are created by root user, so we can:
666
👿 mask on fileMaking files writable do not impose security risk. If attacker would get access to the container he can switch configuration to any file he wants and then send HUP signal to the nginx process to reload it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but I think GID remains the same. So some other images
g+rw
is used to allow running with arbitrary user.