fix: correctly parse the test results - result can be nullable (#86)

sclorg · Jan 18, 2024 · 6e54f92 · 6e54f92
1 parent 6cb0ef2
commit 6e54f92
Show file tree

Hide file tree

Showing 10 changed files with 41 additions and 36 deletions.
diff --git a/dist/action.js b/dist/action.js
diff --git a/dist/action.js.map b/dist/action.js.map
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/dist/schema/testing-farm-api.d.ts b/dist/schema/testing-farm-api.d.ts
diff --git a/dist/schema/testing-farm-api.js b/dist/schema/testing-farm-api.js
diff --git a/dist/schema/testing-farm-api.js.map b/dist/schema/testing-farm-api.js.map
diff --git a/src/action.ts b/src/action.ts
@@ -186,7 +186,7 @@ async function action(pr: PullRequest): Promise<void> {
 
   // Get final state of Testing Farm scheduled request
   const state = tfResult.state;
-  const result = tfResult.result.overall;
+  const result = tfResult.result ? tfResult.result.overall : 'unknown';
   let finalState: Endpoints['POST /repos/{owner}/{repo}/statuses/{sha}']['parameters']['state'] =
     'success' as const;
   let infraError = '';
@@ -264,7 +264,13 @@ async function action(pr: PullRequest): Promise<void> {
 
   // Exit with error in case of failure in test
   if (finalState === 'failure') {
-    throw new Error(`Testing Farm test failed - ${tfResult.result.summary}`);
+    throw new Error(
+      `Testing Farm test failed - ${
+        tfResult.result
+          ? tfResult.result.summary ?? 'No summary provided'
+          : 'No summary provided'
+      }`
+    );
   }
 }
 

diff --git a/src/schema/testing-farm-api.ts b/src/schema/testing-farm-api.ts
@@ -8,10 +8,12 @@ export type Request = z.infer<typeof requestSchema>;
 
 export const requestDetailsSchema = z.object({
   state: z.string(),
-  result: z.object({
-    summary: z.union([z.string(), z.null()]),
-    overall: z.string(),
-  }),
+  result: z
+    .object({
+      summary: z.union([z.string(), z.null()]),
+      overall: z.string(),
+    })
+    .nullable(),
 });
 
 export type RequestDetails = z.infer<typeof requestDetailsSchema>;
diff --git a/tests/action.test.ts b/tests/action.test.ts
@@ -187,22 +187,10 @@ describe('Integration test', () => {
       }
     );
     vi.mocked(mocks.requestDetails)
-      .mockResolvedValueOnce({
-        state: 'new',
-        result: { overall: '', summary: null },
-      })
-      .mockResolvedValueOnce({
-        state: 'queued',
-        result: { overall: '', summary: null },
-      })
-      .mockResolvedValueOnce({
-        state: 'pending',
-        result: { overall: '', summary: null },
-      })
-      .mockResolvedValueOnce({
-        state: 'running',
-        result: { overall: '', summary: null },
-      })
+      .mockResolvedValueOnce({ state: 'new', result: null })
+      .mockResolvedValueOnce({ state: 'queued', result: null })
+      .mockResolvedValueOnce({ state: 'pending', result: null })
+      .mockResolvedValueOnce({ state: 'running', result: null })
       .mockResolvedValueOnce({
         state: 'complete',
         result: { overall: 'passed', summary: '\\o/' },