Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update summary link and update failed status description #91

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Update summary link and update failed status description #91

merged 4 commits into from
Dec 12, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Dec 7, 2023

No description provided.

from: `Testing Farm test failed - summary`
to: `Build finished${infraError} - summary`
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a26046b) 99.36% compared to head (d5a4753) 99.37%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           typescript      #91      +/-   ##
==============================================
+ Coverage       99.36%   99.37%   +0.01%     
==============================================
  Files               5        6       +1     
  Lines             469      482      +13     
  Branches           46       50       +4     
==============================================
+ Hits              466      479      +13     
  Misses              3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I have just a few minor notes.

tests/action.test.ts Outdated Show resolved Hide resolved
@jamacku
Copy link
Member Author

jamacku commented Dec 8, 2023

I have updated the util tests so the results look more readable and authentic.

@zmiklank zmiklank merged commit 4dea32b into sclorg:typescript Dec 12, 2023
5 checks passed
@jamacku jamacku deleted the fix-summary branch December 12, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants