feat(doas): new completion #766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachi107
reviewed
Apr 16, 2024
| _command_offset $i | ||
| return | ||
| fi | ||
| [[ ${words[i]} == -@(!(-*)[uCLs]) ]] && |
There was a problem hiding this comment.
What's the difference between what you wrote and my suggestion below? They both seem to work, but my suggestion seems simpler.
Suggested change
| [[ ${words[i]} == -@(!(-*)[uCLs]) ]] && | |
| [[ ${words[i]} == -@([uCLs]) ]] && |
| done | ||
|
|
||
| case "$prev" in | ||
| -!(-*)u) |
There was a problem hiding this comment.
Same as above; I simply use -u and -C in my personal doas completion file.
There was a problem hiding this comment.
That will fail to match the case where u or C is the last in a set of bundled short options, like doas -nu <TAB>. Similarly above.
|
Makes sense, thanks for the explanation!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #505