-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: added check-version subcommand
Signed-off-by: Ben Meier <[email protected]>
- Loading branch information
1 parent
b3d7fe1
commit fa90270
Showing
5 changed files
with
185 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
package command | ||
|
||
import ( | ||
"github.com/spf13/cobra" | ||
|
||
"github.com/score-spec/score-compose/internal/version" | ||
) | ||
|
||
var checkVersionCmd = &cobra.Command{ | ||
Use: "check-version [constraint]", | ||
Short: "Assert that the version of score-compose matches the required constraint", | ||
Long: `score-compose is commonly used in Makefiles and CI pipelines which may depend on a particular functionality | ||
or a particular default provisioner provided by score-compose init. This command provides a common way to check that | ||
the version of score-compose matches a required version. | ||
`, | ||
Example: ` | ||
# check that the version is exactly 1.2.3 | ||
score-compose check-version =v1.2.3 | ||
# check that the version is 1.3.0 or greater | ||
score-compose check-version >v1.2 | ||
# check that the version is equal or greater to 1.2.3 | ||
score-compose check-version >=1.2.3`, | ||
Args: cobra.ExactArgs(1), | ||
SilenceErrors: true, | ||
CompletionOptions: cobra.CompletionOptions{DisableDefaultCmd: true}, | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
cmd.SilenceUsage = true | ||
return version.AssertVersion(args[0], version.Version) | ||
}, | ||
} | ||
|
||
func init() { | ||
rootCmd.AddCommand(checkVersionCmd) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
package command | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestCheckVersionHelp(t *testing.T) { | ||
stdout, stderr, err := executeAndResetCommand(context.Background(), rootCmd, []string{"check-version", "--help"}) | ||
assert.NoError(t, err) | ||
assert.Equal(t, `score-compose is commonly used in Makefiles and CI pipelines which may depend on a particular functionality | ||
or a particular default provisioner provided by score-compose init. This command provides a common way to check that | ||
the version of score-compose matches a required version. | ||
Usage: | ||
score-compose check-version [constraint] [flags] | ||
Examples: | ||
# check that the version is exactly 1.2.3 | ||
score-compose check-version =v1.2.3 | ||
# check that the version is 1.3.0 or greater | ||
score-compose check-version >v1.2 | ||
# check that the version is equal or greater to 1.2.3 | ||
score-compose check-version >=1.2.3 | ||
Flags: | ||
-h, --help help for check-version | ||
Global Flags: | ||
--quiet Mute any logging output | ||
-v, --verbose count Increase log verbosity and detail by specifying this flag one or more times | ||
`, stdout) | ||
assert.Equal(t, "", stderr) | ||
|
||
stdout2, stderr, err := executeAndResetCommand(context.Background(), rootCmd, []string{"help", "check-version"}) | ||
assert.NoError(t, err) | ||
assert.Equal(t, stdout, stdout2) | ||
assert.Equal(t, "", stderr) | ||
} | ||
|
||
func TestCheckVersionPass(t *testing.T) { | ||
stdout, stderr, err := executeAndResetCommand(context.Background(), rootCmd, []string{"check-version", ">=0.0.0"}) | ||
assert.NoError(t, err) | ||
assert.Equal(t, stdout, "") | ||
assert.Equal(t, "", stderr) | ||
} | ||
|
||
func TestCheckVersionFail(t *testing.T) { | ||
stdout, stderr, err := executeAndResetCommand(context.Background(), rootCmd, []string{"check-version", ">99"}) | ||
assert.EqualError(t, err, "current version 0.0.0 does not match requested constraint >99") | ||
assert.Equal(t, stdout, "") | ||
assert.Equal(t, "", stderr) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package version | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestAssertVersion_good(t *testing.T) { | ||
for _, tup := range [][2]string{ | ||
{"=1.2.3", "v1.2.3"}, | ||
{">=1.2.3", "v1.2.3"}, | ||
{">=1.2.3", "v1.2.4"}, | ||
{">1.2.3", "v1.2.4"}, | ||
{">=1.1", "1.1.0"}, | ||
{">=1.1", "1.2.0"}, | ||
{">=1", "1.0.0"}, | ||
{">1", "2.0.0"}, | ||
} { | ||
t.Run(fmt.Sprintf("%v", tup), func(t *testing.T) { | ||
assert.NoError(t, AssertVersion(tup[0], tup[1])) | ||
}) | ||
} | ||
} | ||
|
||
func TestAssertVersion_bad(t *testing.T) { | ||
for _, tup := range [][3]string{ | ||
{"=1.2.3", "v1.2.0", "current version v1.2.0 does not match requested constraint =1.2.3"}, | ||
{">2", "v1.2.0", "current version v1.2.0 does not match requested constraint >2"}, | ||
{">1.2", "v1.2.0", "current version v1.2.0 does not match requested constraint >1.2"}, | ||
} { | ||
t.Run(fmt.Sprintf("%v", tup), func(t *testing.T) { | ||
assert.EqualError(t, AssertVersion(tup[0], tup[1]), tup[2]) | ||
}) | ||
} | ||
} |