Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the init_test #200

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

7h3-3mp7y-m4n
Copy link
Contributor

Fixed the main_init_test.go

Description

The following TestInitWithProvisioners often fails , so by adding this new lines will help to check whether the expected provisioner URI is present in the provs collection of provisions or not..

What does this PR do?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
@7h3-3mp7y-m4n
Copy link
Contributor Author

here is test check by running it for 15 times
Screenshot 2024-11-01 at 7 57 40 PM

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, more consistency with what was done in score-k8s recently, thanks for bringing this here too!
score-spec/score-k8s#58

This will avoid this random/flaky failure in CI: https://github.com/score-spec/score-compose/actions/runs/11630107976/job/32388355937?pr=199

@mathieu-benoit
Copy link
Contributor

@astromechza, quick review on this one please? Thanks!

@mathieu-benoit mathieu-benoit merged commit e8c481f into score-spec:main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants