fix: remove default replicas=1 value from workload conversion #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While it's done for |
Signed-off-by: Ben Meier <[email protected]>
astromechza
force-pushed
the
remove-default-repliaces
branch
from
f2601a1
to
d807854
Compare
Signed-off-by: Ben Meier <[email protected]>
astromechza
requested review from
mathieu-benoit,
chrishumanitec and
sujaya-sys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mentioned in #25 as causing issues with deployments that have an HPA or have been scaled up by hand already. I'm not entirely sure why we had this default, possibly due to a previous proof of concept or example. Not breaking change since 1 is the default replicas.
Thanks @maxstepanov for bringing this to our attention!