Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test coverage and renamed existing test files to allow coverage to work #886

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

carpecodeum
Copy link

Description

Added test coverage to existing tests and displayed them in an orderly fashion. Added extra commands to run all the tests at once. Also, edited the names of the existing tests files to allow the test coverage to work.

Related Issue #851

Motivation and Context

The project was lacking the magnitude and the reach of the impact of the existing tests have on the whole flask backend this can help ensure maximum efficiency of the reach of the test cases present.

How Has This Been Tested?

Screenshot 2020-02-12 at 1 04 22 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@carpecodeum
Copy link
Author

@JaDogg @kmehant can you please review this please!

@@ -0,0 +1,46 @@
import unittest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this file do? is it a script?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file adds a command for running the tests without the coverage and with the coverge the respective commands being python TestCommands.py test and python TestCommands.py cov

@carpecodeum
Copy link
Author

@JaDogg For running the tests the command is python TestCommands.py test

from UserManager import *
import unittest


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why there are two blank lines between code blocks instead of one?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No these are left because of keeping the code easy to read but if you think i will remove the extra line.



if __name__ == '__main__':
manager.run()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line at the end of the file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay i will

… the tests at once and renamed the existing test files for coverage to work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants