Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add show password feature #901

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add show password feature #901

wants to merge 3 commits into from

Conversation

sahandilshan
Copy link

Description

Allow users to view password while typing

Related Issue

Fix #900

Motivation and Context

Sometimes the user needs to verify the password before hits the login button.

Screenshots (In case of UI changes):

pass1
pass2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deshankoswatte deshankoswatte deshankoswatte left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahandilshan @deshankoswatte