User and Stack Routes Structured #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching Changes from Main Repo
User and Stack Routes Structured
|
@tharindupr Please have a look at the PR |
tharindupr
approved these changes
Jun 13, 2018
|
Fix this warning in the PR as well WARNING: |
psnmissaka
reviewed
Jun 13, 2018
stackle_api/app/models/stack.js
Outdated
| const validator = new Validator(request.body); | ||
| const input = validator.validateCreateStack(); | ||
| console.log('Input : ', input); |
There was a problem hiding this comment.
remove the console log
|
Not related to this issue but in the API endpoint |
psnmissaka
reviewed
Jun 13, 2018
There was a problem hiding this comment.
Good job @shivamarora96 Check the comments I have added and once they are fixed we can go ahead with the merge.
|
Sure @psnmissaka |
1. Add option to db.connect if mongoose version is less than 5 2. Post create validation improved 3. un-necessary Console.log removed
|
@psnmissaka @tharindupr changes made, kindly review it. #106 |
psnmissaka
approved these changes
Jun 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.