-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WJ-1196] [WJ-1031] Add support for S3 presign URLs to upload blobs #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmiegit
force-pushed
the
WJ-1196-presign
branch
from
June 12, 2024 11:22
a39aed2
to
7d6aeb7
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
2 times, most recently
from
July 11, 2024 04:42
e0d8218
to
1001d8d
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
from
August 20, 2024 02:41
1001d8d
to
1df64c8
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
2 times, most recently
from
September 8, 2024 22:38
3bced8d
to
b1a00ae
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
3 times, most recently
from
September 20, 2024 05:18
9ce6102
to
df1c682
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
from
September 29, 2024 03:06
eab803f
to
528b0a7
Compare
emmiegit
force-pushed
the
WJ-1196-presign
branch
2 times, most recently
from
October 3, 2024 07:27
c606827
to
a3b3be7
Compare
Also clears blobs that are too big, if uploaded.
emmiegit
force-pushed
the
WJ-1196-presign
branch
from
October 6, 2024 06:46
8b05a7f
to
007c022
Compare
emmiegit
changed the title
[WJ-1196] Add support for S3 presign URLs to upload blobs
[WJ-1196] [WJ-1031] Add support for S3 presign URLs to upload blobs
Oct 6, 2024
Introducing Python-isms like capitalized bool values and single-quoted strings is not going to be helpful when working with Rust.
Zokhoi
approved these changes
Oct 7, 2024
thanks @Zokhoi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the upload process to use S3 presign URLs. See the Jira issue to understand why we are changing the upload system.
This PR has a number of corresponding changes:
blob_pending
table to track in-progress uploads. This table will use cuids to generate external IDs, like other non-public data scopes such as messages.BlobService
methods for creating, cancelling, and finishing pending blob uploads. The last is not in the JSONRPC API but is instead called by the relevant services instead.echo
API request, for testing purposes.ProvidedValue
that prevents it from being used to serialize data.