Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update korean language #1014

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update korean language #1014

wants to merge 3 commits into from

Conversation

cedar101
Copy link

@cedar101 cedar101 commented Nov 1, 2021

add 'ko-KR' to locale_specific.

@Gallaecio Gallaecio added language language related issue/PR Type: Enhancement labels Nov 1, 2021
@atharmohammad
Copy link
Contributor

atharmohammad commented Nov 1, 2021

@cedar101 Don't add directly into .py files . you have to create a ko.yaml file in dateparser_data/supplementary_language_data/date_translation_data and add those changes there and then run script
python write_complete_data.py in dateparser_scripts which will automatically make these changes in the py file
read this Contribution Guidelines for more details
In the end you can always run tox in root directory to check if all tests are passing as some other tests of relative dates are also failing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language language related issue/PR Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants