Fix short weekday names #1214
Open
Fix short weekday names #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check https://github.com/scrapinghub/dateparser/blob/master/CONTRIBUTING.rst#guidelines-for-editing-translation-data about editing language data (you edited a generated file). |
adnan-awan
force-pushed
the
fix-short-weekday-names-1170
branch
from
1e4c73c
to
30e2c7f
Compare
- Update en.yaml file to support two letters days of the week - #1170
|
Any idea about the failing test? |
- Develop method to remove_multiple_occurrences of the day(s) of the week - #1170
Gallaecio
reviewed
Jan 30, 2024
Comment on lines
+125
to
+135
| def remove_multiple_occurrences(self, date_str_tokens: list): | ||
| # first occurrence of day of the week will be considered | ||
| # followings occurrence(s) will be skipped and removed from the token list. | ||
| weekdays_counter = 0 | ||
| for i, token in enumerate(date_str_tokens): | ||
| if token in self.weekdays: | ||
| weekdays_counter += 1 | ||
|
|
||
| if weekdays_counter > 1: | ||
| date_str_tokens.pop(i) | ||
| continue |
There was a problem hiding this comment.
Interesting solution. I imagine it is not perfect, but if current tests pass, onward! We can always iterate on it later.
|
Could you add tests for the fix itself? (7 dates with the short weekday form that are properly parsed) I think that’s all that’s left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1170