Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove convert_to_local_tz #847

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noviluni
Copy link
Collaborator

This function is not used, is not documented, it's not tested and there isn't any reference anywhere (https://github.com/scrapinghub/dateparser/search?q=convert_to_local_tz).

However removing it directly could be considered as a breaking change.

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #847 (8329713) into master (6fb6e37) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   98.37%   98.41%   +0.03%     
==========================================
  Files         231      231              
  Lines        2591     2589       -2     
==========================================
- Hits         2549     2548       -1     
+ Misses         42       41       -1     
Impacted Files Coverage Δ
dateparser/timezone_parser.py 100.00% <ø> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb6e37...8329713. Read the comment docs.

@Gallaecio
Copy link
Member

Time for a 2.0 milestone? 🙂

@noviluni noviluni added this to the 2.0.0 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants